Fix: Record TOC navigations in history (#1248) #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Jinash-Rouniyar This is for #1248 (comment). Alt + Right is just forward navigation. This looks more like a bug of your own code. |
Author
|
@kelson42 I have resolved the issues and TOC navigation is working as expected. I have now marked this pull request ready for review. Thanks. |
kelson42
force-pushed
the
fix-toc-history-1248
branch
from
957abc8 to
0b11cfd
Compare
kelson42
force-pushed
the
fix-toc-history-1248
branch
from
0b11cfd to
fbf9f2b
Compare
Author
|
Hi @kelson42 , I noticed this PR is still open. Since you’ve force-pushed to the branch before, I wanted to check: do you still want me to rebase/update the PR if it is still useful, or would it be better to close it for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the previous pull request, which contained unrelated changes. This PR addresses issue #1248 by ensuring that TOC navigation actions are properly recorded in the in-page history, while still allowing JavaScript to handle scrolling. This prevents unnecessary page refreshes that would reset DOM states. The commit has been cleaned up to only include the relevant changes.
@kiwix/lieutenants Please review when available.